Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for the client-side caching breaking GeoJSON sources #82

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

petrsloup
Copy link
Member

@petrsloup petrsloup commented Apr 19, 2024

RD-254

Objective

Loading GeoJSON sources from api.maptiler.com is currently broken due to a bug in the client-side caching mechanism

Description

More robust filtering. ResourceType was not enough, because the same value is actually used for TileJSONs and GeoJSONs.

Checklist

  • I have added relevant info to the CHANGELOG.md

@petrsloup petrsloup self-assigned this Apr 19, 2024
@petrsloup petrsloup marked this pull request as ready for review April 19, 2024 09:54
Copy link
Collaborator

@jonathanlurie jonathanlurie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@petrsloup petrsloup merged commit db79e06 into main Apr 24, 2024
1 check passed
@petrsloup petrsloup deleted the RD-254_geojson-caching-bug branch April 24, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants